Fix uploading background images in stylebook view. #68159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tellthemachines
added
[Type] Bug
|
Size Change: +54 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 66c37f3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12423696965
|
ramonjd
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Thanks for the quick PR.
The upload dropdown is now back for the style book after refreshing the page!
| Before | After |
|---|---|
 |
 |
|
I tested normal functionality: uploading, selecting from media library and resetting and all work as expected.
Just for good measure I checked the style book in the editor, though I know it's not connected. All good!
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes this issue.
Because there's no editor rendered in the style book view, the block editor settings aren't updated with the media upload function, even if user has the required permissions.
As a side note, and something to potentially address as a follow up, should we really require upload permissions to access the media library? As it stands without upload the whole dropdown is inaccessible:
I'm guessing that if you have access to the site editor you probably also have upload permissions, but maybe worth thinking about.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast